Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky registry test #278

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

BrianJKoopman
Copy link
Member

Description

Fix a flaky registry test.

Motivation and Context

This registry test would occasionally fail, as it was relying on catching the state of the main registry process in STOPPING to pass. The failure was that sometimes it'd still be RUNNING. The fix is to just wait for the process to end and check that it SUCCEEDED.

How Has This Been Tested?

Tested locally by running the test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

@BrianJKoopman BrianJKoopman added the bug Something isn't working label Jul 27, 2022
@BrianJKoopman BrianJKoopman merged commit 971bac7 into develop Jul 27, 2022
@BrianJKoopman BrianJKoopman deleted the koopman/fix-flaky-registry-test branch July 27, 2022 19:29
@BrianJKoopman BrianJKoopman mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant