Add SITE_HOST envvar to ocs-agent-cli #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See above.
Motivation and Context
Primary motivation is to make it easier to configure a single HostManager to control all agents on a physical host, including ones managed through docker and a docker-compose.yaml file.
In our new docker service definition scheme, environment variables are used to set basic agent configuration. This adds SITE_HOST to INSTANCE_ID, SITE_HUB, SITE_HTTP. The SITE_* ones can be defined in an anchor, and used throughout the docker-compose file; e.g.:
Use of anchors in this way does require treating environment as a dict rather than a list.
How Has This Been Tested?
Directly by manipulating the configuration of the docker-compose.yaml. The argument remains optional, and has the correct default behaviors.
Types of changes
Checklist: