Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in how args are parsed from site-config #378

Merged
merged 1 commit into from Mar 27, 2024
Merged

Conversation

jlashner
Copy link
Collaborator

Small change to fix the bug kyohei found here: #377
Turns out the ArgContainer site-config uses to parse site-config args was treating negative numbers like new arguments, which was causing some issues.

Description

ArgContainer now checks that the first char after leading hyphens is in the alphabet, when determining if it should create a new arg entry.

Motivation and Context

#377

How Has This Been Tested?

Tested locally that new namespace looks like I'd expect

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jlashner jlashner requested a review from mhasself March 27, 2024 15:22
@jlashner jlashner mentioned this pull request Mar 27, 2024
@BrianJKoopman BrianJKoopman merged commit 4d79ade into main Mar 27, 2024
4 checks passed
@BrianJKoopman BrianJKoopman deleted the argparse_bugfix branch March 27, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants