Fixes for running on Apple Silicon #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 26, 2022 22:24
Including this file causes problems on Apple Silicon, since it implements x86 instructions that are not available on Silicon.
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
+ Coverage 44.43% 44.48% +0.05%
==========================================
Files 33 33
Lines 9745 9745
==========================================
+ Hits 4330 4335 +5
+ Misses 5415 5410 -5
Continue to review full report at Codecov.
|
|
Thanks! Looks good to me but @mhasself might want to weigh in. |
msyriac
approved these changes
Jul 27, 2022
Fine with me ... I'm not a heavy libsharp user though. |
msyriac
added a commit
that referenced
this pull request
Mar 22, 2024
* 'master' of github.com:simonsobs/pixell: (34 commits) Added support for constructing enplot annotations without using a text file Fixes for running on Apple Silicon (#196) More robust lmul Added enmap.contains tweak argument in quad_weights utils.remove_nan and utils.without_nan Added matched_filter_constcorr_dual. Will test if this is better than lowcorr utils.bincount Support skew-like transformations in constcorr Added roll_rows Bump version: 0.15.3 → 0.16.0 update HISTORY Modernize HDF (#192) optional args to 'method' version of enmap.upgrade (#190) Added pointsrcs.radial_bin. Fixed typo in sim_objects bump mac wheel libomp to 14.0.4. OSX target is unchanged. replace clobber by overwrite everywhere Added transpose option to sim_objects. Could be useful for some likelihood calculations Change clobber argument to overwrite Dynamic interpolation bound in tsz_tform ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are two changes that allow for installation on Apple Silicon computers:
setup.pylooks in/usr/local/bin/forgccif it detects macOS. This is where homebrew installs things on Intel Macs, but on Silicon, homebrew instead puts things in/opt/homebrew/bin/(see https://docs.brew.sh/FAQ#why-should-i-install-homebrew-in-the-default-location). I've changedsetup.pyto look there ifgccis not found in/usr/local/bin/.cython/sharp_utils.cincludesimmintrin.h, which includes x86 instructions that are not implemented on Silicon. The functions insharp_utils.cthat would use these are already turned off with preprocessor directives, so I've done the same for the#include <immintrin.h>line.