Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move requests package from separate group into install_requires #595

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

BrianJKoopman
Copy link
Member

Description

This PR moves the requests package into the main dependency list.

Motivation and Context

requests is used by four agents now, so I think it makes sense to include in the main dependency group. Also, it was only listed as a requirement for the SynaccessAgent, which missed out on several other agents.

How Has This Been Tested?

In a fresh virtual environment:

$ pip install .
$ pip freeze
attrs==23.1.0
autobahn==23.6.2
Automat==22.10.0
cbor2==5.5.1
certifi==2023.11.17
cffi==1.16.0
charset-normalizer==3.3.2
constantly==23.10.4
cryptography==41.0.7
deprecation==2.1.0
flatbuffers==23.5.26
greenlet==3.0.2
hyperlink==21.0.0
idna==3.6
incremental==22.10.0
influxdb==5.3.1
msgpack==1.0.7
numpy==1.26.2
ocs==0.10.3
packaging==23.2
ply==3.11
py-ubjson==0.16.1
pyasn1==0.4.8
pycparser==2.21
pycryptodomex==3.19.0
pyModbusTCP==0.2.1
pyserial==3.5
pysmi==0.3.4
pysnmp==4.4.12
python-dateutil==2.8.2
pytz==2023.3.post1
PyYAML==6.0.1
requests==2.31.0
setproctitle==1.3.3
six==1.16.0
-e git+ssh://git@github.com/simonsobs/socs.git@9caa5eb8ff0ddb1e77bbad5a1fc6d939eca91854#egg=socs
SQLAlchemy==2.0.23
Twisted==23.10.0
txaio==23.1.1
typing_extensions==4.9.0
ujson==5.9.0
urllib3==2.1.0
zope.interface==6.1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This is used by enough agents now that it makes sense to always include it.
@BrianJKoopman BrianJKoopman merged commit c19e74d into main Dec 11, 2023
7 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/requests branch December 11, 2023 17:41
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
* Move requests package into install_requires

This is used by enough agents now that it makes sense to always include it.

* Remove synacc group from installation docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant