Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration keys in theoryforge_MFLike #168

Closed
ggalloni opened this issue Mar 8, 2024 · 6 comments · Fixed by #170
Closed

Calibration keys in theoryforge_MFLike #168

ggalloni opened this issue Mar 8, 2024 · 6 comments · Fixed by #170

Comments

@ggalloni
Copy link
Collaborator

ggalloni commented Mar 8, 2024

The keys of the calibration parameters in TheoryForge_MFLike._get_calibrated_spectra should be single-letter strings to match the syslib_mflike.Calibration_alm class. This causes the mflike tests to fail.

On my fork, I tested it with the single-letter key (lines 248 and 254) and it works fine.

@sgiardie
Copy link
Collaborator

sgiardie commented Mar 8, 2024

That is true. There have been several updates in mflike that should be ported in soliket. I think the current version of soliket is coherent with version 0.9.0 of LAT_MFLike, while we are now at version 0.9.5 in LAT_MFLike

@itrharrison
Copy link
Collaborator

@sgiardie how big are the changes? Will be able to do them as a small job or will it be a bit of iteration? Otherwise we should pin the required version of syslib.

@sgiardie
Copy link
Collaborator

Yes I think we can correct the bugs quickly. I can take care of that if you prefer

@itrharrison
Copy link
Collaborator

Yes please! 🙏

@itrharrison
Copy link
Collaborator

Probably when you make the change you should also update the correct requirement for syslib version.

@sgiardie
Copy link
Collaborator

There have been also two other modifications in LAT_MFLike unrelated to bugs in mflike/syslibrary, i.e. we have removed any hard coded foreground params and pulled them in the yaml and introduced the possibility for some systematics parameters not to be sampled. Do we want to add also these modifications in soliket?

@sgiardie sgiardie linked a pull request Mar 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants