chore: increase test coverage of BaseInputValueAccessor

simontonsoftware · Jun 22, 2019 · 5b286e6 · 5b286e6
1 parent b1766b2
commit 5b286e6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/projects/ng-app-state/src/lib/nas-model/nas-model.directive.spec.ts b/projects/ng-app-state/src/lib/nas-model/nas-model.directive.spec.ts
@@ -3,6 +3,7 @@ import {
   async,
   ComponentFixture,
   fakeAsync,
+  flushMicrotasks,
   TestBed,
   tick,
 } from "@angular/core/testing";
@@ -671,19 +672,23 @@ describe("nasModel", () => {
   }));
 
   it("can control disabledness", fakeAsync(() => {
-    const store = initTest(NameComponent, NameStore, {
-      extraDirectives: [InnerNameComponent],
-    });
-    store.assign({ isDisabled: true });
+    const store = initSingleValueTest(`
+      <input
+        type="number"
+        [nasModel]="store('num')"
+        [disabled]="store('disabled').$ | async"
+      />
+    `);
+    store.set({ num: 2, disabled: true });
     const input = query("input");
 
     detectChanges();
-    tick(0);
+    flushMicrotasks();
     expect(input.disabled).toBe(true);
 
-    store.assign({ isDisabled: false });
+    store.assign({ disabled: false });
     detectChanges();
-    tick(0);
+    flushMicrotasks();
     expect(input.disabled).toBe(false);
   }));
 });
diff --git a/projects/ng-app-state/src/lib/nas-model/value-accessors/base-input-value-accessor.ts b/projects/ng-app-state/src/lib/nas-model/value-accessors/base-input-value-accessor.ts
@@ -20,7 +20,7 @@ export abstract class BaseInputValueAccessor extends BaseValueAccessor<
     this.element.value = value;
   }
 
-  setDisabledState(isDisabled: boolean): void {
+  setDisabledState(isDisabled: boolean) {
     this.element.disabled = isDisabled;
   }
 }