Implement toCsv #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersimont
reviewed
Sep 2, 2018
| @@ -0,0 +1,21 @@ | |||
| import { toString } from "micro-dash"; | |||
|
|
|||
| export function toCsv(data: any[][]) { | |||
There was a problem hiding this comment.
[green]
Maybe "content" instead of "data"?
| const string = toString(value); | ||
|
|
||
| if (/["|,|\n|\r]/.test(string)) { | ||
| return wrapWithQuotes(string.replace(/"/g, `""`)); |
There was a problem hiding this comment.
[yellow]
Should these regular expressions be extracted into constants outside the function? Or doesn't that matter in javascript?
| } | ||
|
|
||
| function wrapWithQuotes(string: string) { | ||
| return `"${string}"`; |
There was a problem hiding this comment.
[green]
This implementation is shorter than the name of the function. Maybe inline it?
ersimont
requested changes
Sep 2, 2018
| @@ -1,21 +1,20 @@ | |||
| import { toString } from "micro-dash"; | |||
|
|
|||
| export function toCsv(data: any[][]) { | |||
| return data | |||
| export function toCsv(content: any[][]) { | |||
ersimont
approved these changes
Sep 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
toCsv