fix(micro-dash): functions() no longer calls getters

simontonsoftware · Nov 14, 2020 · 145f301 · 145f301
1 parent f29d102
commit 145f301
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/projects/micro-dash/src/lib/object/functions.spec.ts b/projects/micro-dash/src/lib/object/functions.spec.ts
@@ -13,6 +13,17 @@ describe('functions()', () => {
     expect(functions(MyClass.prototype)).toEqual(['b']);
   });
 
+  it("doesn't call getters", () => {
+    class Gotcha {
+      get error(): never {
+        throw new Error('called getter');
+      }
+    }
+    expect(() => {
+      functions(Gotcha.prototype);
+    }).not.toThrowError();
+  });
+
   //
   // stolen from https://github.com/lodash/lodash
   //

diff --git a/projects/micro-dash/src/lib/object/functions.ts b/projects/micro-dash/src/lib/object/functions.ts
@@ -6,10 +6,12 @@ import { StringifiedKey } from '../interfaces';
  *
  * Contribution to minified bundle size, when it is the only function imported:
  * - Lodash: 3,504 bytes
- * - Micro-dash: 225 bytes
+ * - Micro-dash: 310 bytes
  */
 export function functions<T extends object>(obj: T): Array<StringifiedKey<T>> {
   return keys(obj).filter(
-    (key) => key !== 'constructor' && isFunction(obj[key as keyof T]),
+    (key) =>
+      key !== 'constructor' &&
+      isFunction(Object.getOwnPropertyDescriptor(obj, key)?.value),
   );
 }