Skip to content

Commit

Permalink
fix: remove accidental dependency on s-ng-dev-utils
Browse files Browse the repository at this point in the history
  • Loading branch information
ersimont committed Jun 26, 2019
1 parent 22e27c9 commit 6da82c3
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 20 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
"@angular/platform-browser": "~8.0.0",
"@angular/platform-browser-dynamic": "~8.0.0",
"@angular/router": "~8.0.0",
"micro-dash": "^6.0.0",
"micro-dash": "^6.3.0",
"rxjs": "~6.4.0",
"s-rxjs-utils": "^2.0.0",
"s-rxjs-utils": "^2.2.2",
"tslib": "^1.9.0",
"zone.js": "~0.9.1"
},
Expand All @@ -50,7 +50,7 @@
"ng-packagr": "^5.1.0",
"prettier": "^1.14.2",
"protractor": "~5.4.0",
"s-ng-dev-utils": "^0.6.0",
"s-ng-dev-utils": "^0.8.0",
"standard-version": "^6.0.1",
"ts-node": "~7.0.0",
"tsickle": "^0.35.0",
Expand Down
4 changes: 2 additions & 2 deletions projects/s-ng-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"peerDependencies": {
"@angular/common": ">=8.0.0 <9.0.0",
"@angular/core": ">=8.0.0 <9.0.0",
"micro-dash": ">=6.0.0 <7.0.0",
"micro-dash": ">=6.3.0 <7.0.0",
"rxjs": ">=6.4.0 <7.0.0",
"s-rxjs-utils": ">=2.0.0 <3.0.0"
"s-rxjs-utils": ">=2.2.2 <3.0.0"
}
}
5 changes: 2 additions & 3 deletions projects/s-ng-utils/src/lib/form-control-superclass.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { Type } from "@angular/core";
import { ControlValueAccessor, NG_VALUE_ACCESSOR } from "@angular/forms";
import { noop } from "micro-dash";
import { Function0, Function1 } from "s-ng-dev-utils";
import { DirectiveSuperclass } from "./directive-superclass";

/**
Expand Down Expand Up @@ -73,12 +72,12 @@ export abstract class FormControlSuperclass<T> extends DirectiveSuperclass
}

/** Called as angular sets up the binding to this `ControlValueAccessor`. You normally do not need to use it. */
registerOnChange(fn: Function1<T, void>) {
registerOnChange(fn: (value: T) => void) {
this.emitOutgoingValue = fn;
}

/** Called as angular sets up the binding to this `ControlValueAccessor`. You normally do not need to use it. */
registerOnTouched(fn: Function0<void>) {
registerOnTouched(fn: VoidFunction) {
this.onTouched = fn;
}

Expand Down
24 changes: 12 additions & 12 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4892,10 +4892,10 @@ methods@~1.1.2:
resolved "https://registry.yarnpkg.com/methods/-/methods-1.1.2.tgz#5529a4d67654134edcc5266656835b0f851afcee"
integrity sha1-VSmk1nZUE07cxSZmVoNbD4Ua/O4=

micro-dash@^6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/micro-dash/-/micro-dash-6.0.0.tgz#9473dcd24c714a96d5fd7400a8fa10aecf2328f1"
integrity sha512-eVRIkQs6T09GmD9uVAMeOG+1HkTJgLotDWjBkkegJC+YVmQtU4RbJwDnaftFsiaFKjSENzfJNDl7AP+83Oxzow==
micro-dash@^6.3.0:
version "6.3.0"
resolved "https://registry.yarnpkg.com/micro-dash/-/micro-dash-6.3.0.tgz#20700ecb7618c84390326d4a8adf87d68f06ebe8"
integrity sha512-SEWwU3MCzIBpKpYQSaDc9pNLcLQlxnwzRG2mYOMNNJc1O5ZceDCHQq8GABPzrvAFO6GAMFqqdXcY6v3lAVRXsw==
dependencies:
tslib "^1.9.0"
utility-types "^3.4.1"
Expand Down Expand Up @@ -6599,18 +6599,18 @@ rxjs@^6.0.0, rxjs@^6.4.0:
dependencies:
tslib "^1.9.0"

s-ng-dev-utils@^0.6.0:
version "0.6.0"
resolved "https://registry.yarnpkg.com/s-ng-dev-utils/-/s-ng-dev-utils-0.6.0.tgz#2024c665c283d1a987af3ed2246c6d1bc95bb98d"
integrity sha512-8ybqlelrMeSfAqkbcszpo2jivpDP+zJnyzxfzgDgAx5uW6nNieucYsaMXEaRhatmIKUdxKa4vYYFIbbecG3qzQ==
s-ng-dev-utils@^0.8.0:
version "0.8.0"
resolved "https://registry.yarnpkg.com/s-ng-dev-utils/-/s-ng-dev-utils-0.8.0.tgz#5847ddf282029a9a88fd56e8b33a253dd950762c"
integrity sha512-/O/clTjxvweUOTyqRAicA0gDaYGXCkVC1H+CEAwpvR2aPDA+y0pRB+QMEOiw7le/3uoEO7j1DTpA6TIXWX7UHQ==
dependencies:
tslib "^1.9.0"
tslint-config-prettier "^1.18.0"

s-rxjs-utils@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/s-rxjs-utils/-/s-rxjs-utils-2.0.0.tgz#d56f5705ccc39054acc4a44b2ecf93c4bc159d21"
integrity sha512-rGDj8oMFkhhshtSbRydo52DCZ1krw8mhARa3sUc94tYVyCtKX2ZE885vEDEAAu+KHQGhXyqTHrDFG6SyqyFy6A==
s-rxjs-utils@^2.2.2:
version "2.2.2"
resolved "https://registry.yarnpkg.com/s-rxjs-utils/-/s-rxjs-utils-2.2.2.tgz#8f41277e3699c5c9fab88ea0a25141a3ab9c596d"
integrity sha512-RJKk+8AngQOOkOOWlL/ZeXR7+/jNtUk58cMVpkce8fxkbaFtPlR+NUXOKqNrHjpKt2x6j5Ya/VO09nxH+0v5dA==
dependencies:
tslib "^1.9.0"

Expand Down

0 comments on commit 6da82c3

Please sign in to comment.