Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table joins- minor issue #60

Closed
isdsava opened this issue Sep 7, 2016 · 1 comment
Closed

Table joins- minor issue #60

isdsava opened this issue Sep 7, 2016 · 1 comment

Comments

@isdsava
Copy link

isdsava commented Sep 7, 2016

Thank you for this project, it is excellent. Just a minor issue I had with table joins that might help others..

Notice the need to add a space " " in front of the JOIN keyword

@ContentUri( path = Path.SITE_PRICE_LAT_LNG,
type = "vnd.android.cursor.dir/site_price_lat_lng",
table = Path.SITE_PRICE,
join = " JOIN " + BrowserDatabase.FullSites.FULL_SITES + " ON " + BrowserDatabase.SitePrice.SITE_PRICE + "." + SitePriceColumn._ID + " = " + BrowserDatabase.FullSites.FULL_SITES + "." + FullSiteDetailsColumns._ID
)

Otherwise when generated this statement gets mangled

case SITEPRICELATLNG_SITE_PRICE_LAT_LNG: {
SelectionBuilder builder = getBuilder("SitePriceLatLng");
String join = " JOIN site_price ON site_price._id = full_sites._id";
String table = "site_price" + join;

Hope this makes sense

Thanks again

@SimonVT
Copy link
Owner

SimonVT commented Sep 7, 2016

Update your version, this is fixed by 2b82deb :)

@SimonVT SimonVT closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants