Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to return "access forbidden" from API #9

Closed
simonw opened this issue Feb 5, 2020 · 2 comments
Closed

Ability to return "access forbidden" from API #9

simonw opened this issue Feb 5, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Feb 5, 2020

This will allow the underlying API to also perform permission checks, based on the ?host= that is being accessed and the user who is trying to access them.
@simonw simonw added the enhancement New feature or request label Feb 5, 2020
@simonw
Copy link
Owner Author

simonw commented Feb 5, 2020

Could be as simple as returning this JSON instead of the regular {"username": ...} shape:

{
    "forbidden": "You are not allowed to access that page."
}

simonw added a commit that referenced this issue Feb 5, 2020
@simonw
API can now return {"forbidden": reason} to deny access, refs #9
dfe57df
@simonw simonw closed this as completed in 16e8296 Feb 5, 2020
@simonw
Copy link
Owner Author

simonw commented Feb 5, 2020

Documentation: https://github.com/simonw/datasette-auth-existing-cookies#permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw