Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for headers, methods and max_age - added in asgi-cors 1.0 #5

Closed
simonw opened this issue Apr 8, 2024 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Apr 8, 2024

See https://github.com/simonw/asgi-cors/releases/tag/1.0

@simonw simonw added the enhancement New feature or request label Apr 8, 2024
@simonw
Copy link
Owner Author

simonw commented Apr 8, 2024

Got llm-claude-3 with Claude 3 Opus and files-to-prompt to do all of the work for me:

files-to-prompt ../asgi-cors/asgi_cors.py datasette_cors.py | llm -m opus -s \
  'Output a new datasette_cors.py plugin that adds headers and methods and max_age config options'

files-to-prompt test_datasette_cors.py | llm -c \
  'Update these tests to exercise the new options as well'

cat README.md | llm -c \
  'Update the README to document the new config options'

Transcript: https://gist.github.com/simonw/5e379cc3ed610caf8dfbdfe25b19874a

@simonw simonw closed this as completed in 53b126b Apr 8, 2024
simonw added a commit that referenced this issue Apr 8, 2024
simonw added a commit that referenced this issue Apr 8, 2024
@simonw
Copy link
Owner Author

simonw commented Apr 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant