New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename table_get to table_row (nouns are better than verbs in GraphQL land) #36
Comments
Or |
Or |
But |
Options (using
|
Of these options, |
What about |
FWIW, I still like |
Another option: Tools like https://www.graphile.org/postgraphile/examples/ set up fields called {
users_by(id: 12345) {
name
}
} It would still support {
by_search: users_by(search: "simonw") {
name
}
by_filter: users_by(filter: {name: {eq: "simonw"}}) {
name
}
} |
The problem with |
I'm coming round to |
I'm going with |
A bunch of demo queries in https://github.com/simonw/datasette-graphql/blob/006238a7527ee3d7bc0e465d613ef36f6e062dd3/examples/table_row.md {
table_with_rowid_row(rowid: 1) {
name
}
table_with_pk_row(pk: 1) {
pk
name
}
table_with_compound_pk_row(pk1:1, pk2:3) {
name
pk1
pk2
}
users_row(id: 12345) {
name
}
} |
That query in the live demo: I'm happy with this change. Thanks, @aviflax! |
My pleasure, looks great! |
GraphQL prefers nouns to verbs: https://twitter.com/flaximus/status/1291906337052524546
The text was updated successfully, but these errors were encountered: