Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL on final confirmation page needs to use tilde encoding #21

Closed
simonw opened this issue Jun 3, 2022 · 1 comment
Closed

URL on final confirmation page needs to use tilde encoding #21

simonw opened this issue Jun 3, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Jun 3, 2022

I introduced tilde encoding in Datasette 0.61: https://docs.datasette.io/en/stable/changelog.html#v0-61

This template needs to be fixed to use it:

<p>Importing rows into
<a href="/{{ database|quote_plus }}/{{ table|quote_plus }}">{{ table }}</a>
</p>

@simonw simonw added the bug Something isn't working label Jun 3, 2022
@simonw
Copy link
Owner Author

simonw commented Jun 3, 2022

Also this bit:

return Response.json(
{
"url": "/{database}/{table}".format(
database=quote_plus(db.name),
table=quote_plus(filename),
),
"database_path": quote_plus(db.name),
"task_id": task_id,
"bytes_todo": total_size,
}
)

@simonw simonw closed this as completed in a319a37 Jun 3, 2022
simonw added a commit that referenced this issue Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant