Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips #10

Closed
simonw opened this issue Jun 27, 2018 · 6 comments
Closed

Tooltips #10

simonw opened this issue Jun 27, 2018 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@simonw
Copy link
Owner

simonw commented Jun 27, 2018

Vega supports tooltips, but I haven't yet been able to get them to work within this plugin.
@simonw simonw added the help wanted Extra attention is needed label Jun 27, 2018
simonw pushed a commit that referenced this issue Jul 7, 2018
Implemented tooltips, refs #10
6d46cfd 
Also switched to using React.createRef()
@simonw
Copy link
Owner Author

simonw commented Jul 7, 2018

Shipped as 0.6 - see https://datasette-vega-latest.datasette.io/ for a demo.

@simonw simonw closed this as completed Jul 7, 2018
@simonw
Copy link
Owner Author

simonw commented Jul 10, 2018

It would be neat if the tooltip also included the color and size values but only if those options have been set to a column.

simonw pushed a commit that referenced this issue Jul 10, 2018
Include size/color in tooltip if specified, refs #10
ff0ab28
@simonw
Copy link
Owner Author

simonw commented Jul 10, 2018

Demo of size/color tooltip: https://datasette-vega-latest.datasette.io/?url=https%3A%2F%2Ffivethirtyeight.datasettes.com%2Ffivethirtyeight-45d758d%2Fnba-elo%252Fnbaallelo.json#g.mark=bar&g.x_column=game_id&g.x_type=ordinal&g.y_column=pts&g.y_type=quantitative&g.color_column=team_id&g.size_column=year_id

simonw pushed a commit that referenced this issue Jul 10, 2018
Let's try using PYPI_PASSWORD as a secret setting instead, refs #10
5cc4e52
@simonw
Copy link
Owner Author

simonw commented Jul 10, 2018

Oops, that last commit should have referenced #8

@simonw
Copy link
Owner Author

simonw commented Jul 10, 2018

Shipped this in 0.6.1

@simonw
Copy link
Owner Author

simonw commented Jul 10, 2018

Color and size tooltips now shipped to https://fivethirtyeight.datasettes.com/fivethirtyeight-ac35616/most-common-name%2Fsurnames#g.mark=circle&g.x_column=name&g.x_type=ordinal&g.y_column=count&g.y_type=quantitative&g.color_column=pctwhite&g.size_column=rank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw