request.post_vars() no longer discards empty values

simonw · Jun 3, 2020 · 0934844 · 0934844
1 parent 9690ce6
commit 0934844
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/datasette/utils/asgi.py b/datasette/utils/asgi.py
@@ -80,7 +80,7 @@ async def post_vars(self):
             body += message.get("body", b"")
             more_body = message.get("more_body", False)
 
-        return dict(parse_qsl(body.decode("utf-8")))
+        return dict(parse_qsl(body.decode("utf-8"), keep_blank_values=True))
 
     @classmethod
     def fake(cls, path_with_query_string, method="GET", scheme="http"):

diff --git a/tests/test_internals_request.py b/tests/test_internals_request.py
@@ -16,10 +16,14 @@ async def test_request_post_vars():
     }
 
     async def receive():
-        return {"type": "http.request", "body": b"foo=bar&baz=1", "more_body": False}
+        return {
+            "type": "http.request",
+            "body": b"foo=bar&baz=1&empty=",
+            "more_body": False,
+        }
 
     request = Request(scope, receive)
-    assert {"foo": "bar", "baz": "1"} == await request.post_vars()
+    assert {"foo": "bar", "baz": "1", "empty": ""} == await request.post_vars()
 
 
 def test_request_args():