-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Datasette Docker images built for different architectures #1344
Comments
I'm going to release a |
(Should also update https://docs.datasette.io/en/stable/contributing.html#release-process with notes on how this works) |
https://github.com/simonw/datasette/runs/2687196350 is a run of https://github.com/simonw/datasette/blob/main/.github/workflows/push_docker_tag.yml to publish the new |
Related issue: #1272 - being able to run the test suite inside Docker inside GitHub Actions would be incredibly helpful here. |
Job completed in 13m38s - results are here: https://hub.docker.com/r/datasetteproject/datasette/tags?page=1&ordering=last_updated&name=0.57a1 |
Having pushed that to Docker Hub the following seems to work on my laptop:
I'd like to confirm that this is correctly emulating the architecture and running the correct published image though. |
This helps:
|
Shorter version:
OK! Now I need to figure out how to run the full test suite on each one, then I can call this done. |
To run the test suite... need to install a few more dependencies: Lines 71 to 79 in 7b106e1
And then mount the |
This pattern appears to work, executed at the root of a checkout of
|
I need to push a container for 0.57 using this action, and I'm not ready to ship other architecture builds until we have tested them in #1344.
Continuing on from #1319 - now that we have the ability to build Datasette's Docker image against multiple architectures we should test that it works.
We can do this with QEMU emulation, see https://twitter.com/nevali/status/1397958044571602945
The text was updated successfully, but these errors were encountered: