Rename Datasette.__init__(config=) parameter to settings=

[simonw]

While I'm doing this I should rename this internal variable to avoid confusion in the future:

datasette/datasette/app.py

Line 203 in e837095

config=None,

Originally posted by @simonw in #1431 (comment)

[simonw]

Also this method:

datasette/datasette/app.py

Lines 422 to 424 in 77f4629

	def config_dict(self):
	# Returns a fully resolved config dictionary, useful for templates
	return {option.name: self.setting(option.name) for option in SETTINGS}

And the places that use it:

datasette/datasette/views/base.py

Line 617 in fc48468

"config": self.ds.config_dict(),

datasette/datasette/views/database.py

Line 459 in fc48468

"config": self.ds.config_dict(),

Which is used in this template:

datasette/datasette/templates/table.html

Line 204 in 77f4629

{% if next_url and config.allow_csv_stream %}<label><input type="checkbox" name="_stream"> stream all rows</label>{% endif %}

[simonw]

This is going to break some plugins: https://ripgrep.datasette.io/-/ripgrep?pattern=config%3D&literal=on&glob=%21datasette%2F**

datasette-cluster-map/tests/test_cluster_map.py

@pytest.mark.asyncio

async def test_respects_base_url():
ds = Datasette([], memory=True, config={"base_url": "/foo/"})
response = await ds.client.get("/:memory:?sql=select+1+as+latitude,+2+as+longitude")
assert (

datasette-export-notebook/tests/test_export_notebook.py

@pytest.mark.asyncio

async def test_notebook_no_csv(db_path):
datasette = Datasette([db_path], config={"allow_csv_stream": False})
response = await datasette.client.get("/db/big.Notebook")
assert ".csv" not in response.text

datasette-publish-vercel/tests/test_publish_vercel.py

metadata=metadata,
cors=True,
config={"default_page_size": 10, "sql_time_limit_ms": 2000}
).app()
"""

datasette-publish-vercel/datasette_publish_vercel/init.py

metadata=metadata{extras},
cors=True,
config={settings}

).app()

""".strip()

datasette-search-all/tests/test_search_all.py

async def test_base_url(db_path, path):
sqlite_utils.Database(db_path)["creatures"].enable_fts(["name", "description"])
datasette = Datasette([db_path], config={"base_url": "/foo/"})
response = await datasette.client.get(path)
assert response.status_code == 200

I should fix those as soon as this goes out in a release. I won't close this issue until then.

[simonw]

It's only datasette-publish-vercel that will break the actual functionality - the others will have broken tests.

[ashishdotme]

Any workaround for making it work with datasette-publish-vercel. Currently getting below error

module initialization error: init() got an unexpected keyword argument 'config'
module initialization error
init() got an unexpected keyword argument 'config'

[ashishdotme]

Nevermind, had to remove the branch argument in the workflow to make vercel publish work

[ashishdotme]

@simonw I am getting the below issue again now, even after removing branch argument from vercel datasette plugin

module initialization error: init() got an unexpected keyword argument 'config'
module initialization error
init() got an unexpected keyword argument 'config'

[mroswell]

I am getting this when I visit my live Datasette page:

This Serverless Function has crashed.
Your connection is working correctly.
Vercel is working correctly.
500: INTERNAL_SERVER_ERROR
Code: FUNCTION_INVOCATION_FAILED
ID: ...

And in the server logs, I'm getting

[GET] /disinfectants/listN
19:53:14:23
module initialization error: __init__() got an unexpected keyword argument 'config'
module initialization error
__init__() got an unexpected keyword argument 'config'

Which is the same error that @ashishdotme reported above.

[mroswell]

Resolved, with assistance from @ashishdotme (Thank you!)

Updated requirements.txt to include:

datasette==0.59
datasette-publish-vercel==0.11
sqlite-utils==3.6

Ran:

$ pip3 install -r requirements.txt

The site is back at work! Yay!

[simonw]

This issue is obsolete thanks to the new metadata v.s. config change in Datasette 1.0.