Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a confirm step to the drop table API #1887

Closed
Tracked by #1850
simonw opened this issue Nov 14, 2022 · 2 comments
Closed
Tracked by #1850

Add a confirm step to the drop table API #1887

simonw opened this issue Nov 14, 2022 · 2 comments
Labels
json-api
Milestone
Datasette 1.0a0

Comments

@simonw
Copy link
Owner

simonw commented Nov 14, 2022 •
edited
Loading

In playing with the API explorer just now I realized it's way too easy to accidentally drop a table using it.

Originally posted by @simonw in #1871 (comment)

Added drop table API in:
@simonw simonw mentioned this issue Nov 14, 2022
Closed
17 tasks
@simonw
Copy link
Owner Author

simonw commented Nov 14, 2022

I'm going to add a "confirm": true option to the API. Without that, it returns a note about how many rows will be deleted.

simonw added a commit that referenced this issue Nov 14, 2022
@simonw
confirm: true mechanism for drop table API, closes #1887
612da8e
@simonw
Copy link
Owner Author

simonw commented Nov 14, 2022

Updated docs: https://docs.datasette.io/en/1.0-dev/json_api.html#dropping-tables

@simonw simonw closed this as completed Nov 14, 2022
@simonw simonw modified the milestones: Datasette 1.0, Datasette 1.0a0 Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
json-api
Projects
None yet
Milestone
Datasette 1.0a0
Development

No branches or pull requests
1 participant
@simonw