Deploy failing with "plugins/alternative_route.py: Not a directory"

[simonw]

https://github.com/simonw/datasette/actions/runs/6266449018/job/17017460074

This is a bit of a mystery, I don't think I've changed anything recently that could have broken this.

[simonw]

This looks to be the step that is failing:

datasette/.github/workflows/deploy-latest.yml

Lines 50 to 60 in 80a9cd9

	- name: Set up the alternate-route demo
	run: |
	echo '
	from datasette import hookimpl
	@hookimpl
	def startup(datasette):
	db = datasette.get_database("fixtures2")
	db.route = "alternative-route"
	' > plugins/alternative_route.py
	cp fixtures.db fixtures2.db

[simonw]

Maybe plugins/ does not exist? It should have been created by this line:

datasette/.github/workflows/deploy-latest.yml

Lines 41 to 42 in 80a9cd9

	- name: Build fixtures.db
	run: python tests/fixtures.py fixtures.db fixtures.json plugins --extra-db-filename extra_database.db

[simonw]

I think I see the problem - it's from here: b2ec871#diff-5dbc88d6e5c3615caf10e32a9d6fc6ff683f5b5814948928cb84c3ab91c038b6L770

The config and metadata Click options are the wrong way round:

datasette/tests/fixtures.py

Lines 785 to 786 in 80a9cd9

	@click.argument("metadata", required=False)
	@click.argument("config", required=False)

datasette/tests/fixtures.py

Line 801 in 80a9cd9

def cli(db_filename, config, metadata, plugins_path, recreate, extra_db_filename):

[simonw]

New error: "Error: Metadata should end with .json"

https://github.com/simonw/datasette/actions/runs/6266720924/job/17018265851

[simonw]

Correct usage is now:

python tests/fixtures.py fixtures.db fixtures-config.json fixtures-metadata.json \
  plugins --extra-db-filename extra_database.db

Test tables written to fixtures.db
- metadata written to fixtures-metadata.json
- config written to fixtures-config.json
  Wrote plugin: plugins/register_output_renderer.py
  Wrote plugin: plugins/view_name.py
  Wrote plugin: plugins/my_plugin.py
  Wrote plugin: plugins/messages_output_renderer.py
  Wrote plugin: plugins/sleep_sql_function.py
  Wrote plugin: plugins/my_plugin_2.py
Test tables written to extra_database.db

[simonw]

... which raises the challenge that datasette publish doesn't yet know what to do with a config file!

datasette/.github/workflows/deploy-latest.yml

Lines 114 to 122 in 2da1a6a

	datasette publish cloudrun fixtures.db fixtures2.db extra_database.db \
	-m metadata.json \
	--plugins-dir=plugins \
	--branch=$GITHUB_SHA \
	--version-note=$GITHUB_SHA \
	--extra-options="--setting template_debug 1 --setting trace_debug 1 --crossdb" \
	--install 'datasette-ephemeral-tables>=0.2.2' \
	--service "datasette-latest$SUFFIX" \
	--secret $LATEST_DATASETTE_SECRET

[simonw]

I'm going to disable this bit of the deploy for the moment, which will break the demo linked to from https://simonwillison.net/2022/Dec/2/datasette-write-api/

datasette/.github/workflows/deploy-latest.yml

Lines 91 to 97 in 2da1a6a

	- name: Make some modifications to metadata.json
	run: |
	cat fixtures.json | \
	jq '.databases |= . + {"ephemeral": {"allow": {"id": "*"}}}' | \
	jq '.plugins |= . + {"datasette-ephemeral-tables": {"table_ttl": 900}}' \
	> metadata.json
	cat metadata.json

[simonw]

That worked

e4f8688 is the latest commit right now and https://latest.datasette.io/-/versions shows that as the deployed version.