Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query_actions plugin hook - like table_actions and database_actions for the query/canned query page #2283

Closed
simonw opened this issue Feb 27, 2024 · 2 comments

Comments

@simonw
Copy link
Owner

simonw commented Feb 27, 2024

I just noticed that this page: https://latest.datasette.io/fixtures?sql=select+*+from+facetable

Doesn't fire the database_actions() plugin hook, and so cannot have extra actions added to it.

I think a query_actions() hook would be good here, similar to table_actions() and database_actions(). It could work for both arbitrary SQL queries and canned queries.

This would enable things like https://datasette.io/plugins/datasette-saved-queries to include a menu item for creating and saving a query.

@simonw
Copy link
Owner Author

simonw commented Feb 28, 2024

Implemented with tests and documentation in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant