Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to customize various facet settings #264

Closed
simonw opened this issue May 16, 2018 · 1 comment
Closed

Make it possible to customize various facet settings #264

simonw opened this issue May 16, 2018 · 1 comment

Comments

@simonw
Copy link
Owner

simonw commented May 16, 2018

The new Facets implementation from #255 includes several hard-coded settings which should be made configurable somehow:

Number of rows to return in a facet (maybe this should also be an option that can be set via quersytring argument, e.g. ?_facet=qSpecies:40):

FACET_SIZE = 20

Time limit for executing a facet:

facet_rows = await self.execute(
name, facet_sql, params,
truncate=False, custom_time_limit=200
)

Maximum unique values returned in order for a column to be suggested as a facet:

# Detect suggested facets
FACET_LIMIT = 30

Time limit for calculating if a column should be a suggested facet:

distinct_values = await self.execute(
name, suggested_facet_sql, params,
truncate=False, custom_time_limit=50
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant