Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--limit= CLI option for setting limits #270

Closed
simonw opened this issue May 17, 2018 · 1 comment
Closed

--limit= CLI option for setting limits #270

simonw opened this issue May 17, 2018 · 1 comment

Comments

@simonw
Copy link
Owner

simonw commented May 17, 2018

#264 calls for four new datasette limit options, on top of the two existing ones:

  • --max_returned_rows
  • --sql_time_limit_ms

These are already clogging up datasette serve --help a bit.

How about this syntax instead?

datasette --limit max_returned_rows:100 \
    --limit facet_timeout_ms:500 demo.db

Then we can add as many new user over-rideable limits as we like without clogging up --help too much - though it would be good to have a way of optionally listings their documentation as well.

@simonw simonw closed this as completed in cef9a9a May 18, 2018
@simonw
Copy link
Owner Author

simonw commented May 18, 2018

I'm going to add a /-/limits page that shows the current limits.

@simonw simonw reopened this May 18, 2018
@simonw simonw closed this as completed in 39426ff May 18, 2018
@simonw simonw changed the title Idea: --limit= CLI option for setting limits --limit= CLI option for setting limits May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant