Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to "publish cloudrun" with no user input #457

Closed
simonw opened this issue May 9, 2019 · 2 comments
Closed

Ability to "publish cloudrun" with no user input #457

simonw opened this issue May 9, 2019 · 2 comments
Labels

Comments

@simonw
Copy link
Owner

simonw commented May 9, 2019

If you attempt to deploy a new version of a cloudrun deployment, the script currently pauses and asks for user input for the service name like this:

Service name: (sf-trees):  USER INPUT REQUIRED HERE
Deploying container to Cloud Run service [sf-trees] in project [datasette-222320] region [us-central1]
✓ Deploying... Done.                                                                                                                                                     
  ✓ Creating Revision...                                                                                                                                                 
  ✓ Routing traffic...                                                                                                                                                   
  ✓ Setting IAM Policy...                                                                                                                                                

This is incompatible with running under CI.

@simonw simonw added the small label May 9, 2019
@simonw
Copy link
Owner Author

simonw commented May 9, 2019

From https://cloud.google.com/sdk/gcloud/reference/beta/run/deploy it looks like the service can be provided as an optional positional argument. How about datasette publish cloudrun ... --service=sf-trees

@simonw simonw closed this as completed in b80b03a May 9, 2019
simonw added a commit that referenced this issue May 9, 2019
@simonw
Copy link
Owner Author

simonw commented May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant