Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull m2m faceting out of master so we can ship a release without it #550

Closed
simonw opened this issue Jul 7, 2019 · 1 comment
Closed

Pull m2m faceting out of master so we can ship a release without it #550

simonw opened this issue Jul 7, 2019 · 1 comment
Milestone
Datasette 0.29

Comments

@simonw
Copy link
Owner

simonw commented Jul 7, 2019

After spending some time with #495 I believe I need to make some pretty major changes to how m2m faceting works. I don't want it to block the release of ASGI Datasette so I'm going to revert it back out of master for the moment and merge it back in after the release has gone out.
@simonw simonw added this to the Datasette 0.29 milestone Jul 7, 2019
@simonw
Copy link
Owner Author

simonw commented Jul 7, 2019

Will ship it with #551

@simonw simonw closed this as completed in c5542ab Jul 7, 2019
simonw added a commit that referenced this issue Jul 8, 2019
@simonw
Removed facet-by-m2m from docs, refs #550
aa4cc99 
Will bring this back in #551
simonw added a commit that referenced this issue Nov 11, 2019
@simonw
Removed ManyToManyFacet for the moment, closes #550
04e7fb6
simonw added a commit that referenced this issue Nov 11, 2019
@simonw
Removed facet-by-m2m from docs, refs #550
12e4661 
Will bring this back in #551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Datasette 0.29
Development

No branches or pull requests
1 participant
@simonw