Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin documentation should cover how to bundle static/templates in setup.py #575

Closed
simonw opened this issue Sep 23, 2019 · 1 comment
Closed

Comments

@simonw
Copy link
Owner

simonw commented Sep 23, 2019

These sections here should cover it: https://datasette.readthedocs.io/en/latest/plugins.html#static-assets

Example: https://github.com/simonw/datasette-auth-github/blob/bf01f8f01b87a6cb09c47380ba0a86e0546ebb38/setup.py#L30

package_data={"datasette_auth_github": ["templates/*.html"]},

Also from https://github.com/simonw/datasette-plugin-demos/blob/0ccf9e6189e923046047acd7878d1d19a2cccbb1/setup.py#L18-L22

package_data={
    'datasette_plugin_demos': [
        'static/plugin.js',
    ],
},
@simonw simonw changed the title Plugin documentation should cover how to bundle static/templates in setup,py Plugin documentation should cover how to bundle static/templates in setup.py Sep 23, 2019
@simonw simonw closed this as completed in 10c35bd Oct 24, 2020
@simonw
Copy link
Owner Author

simonw commented Oct 24, 2020

@simonw simonw added this to the 0.51 milestone Oct 24, 2020
simonw added a commit that referenced this issue Oct 24, 2020
Also documented how to package static assets and templates in plugins, closes #575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant