Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review design of JSON output #63

Closed
simonw opened this issue Nov 11, 2017 · 1 comment
Closed

Review design of JSON output #63

simonw opened this issue Nov 11, 2017 · 1 comment

Comments

@simonw
Copy link
Owner

simonw commented Nov 11, 2017

No description provided.

@simonw simonw added the small label Nov 11, 2017
@simonw simonw added this to the Ship v1 milestone Nov 11, 2017
@simonw
Copy link
Owner Author

simonw commented Nov 11, 2017

I'm going to bundle sql and sql_params together into a query nested object like this:

{
    "query": {
        "sql": "select ...",
        "params": {
            "p0": "blah"
        }
    }
}

@simonw simonw closed this as completed in e9e1def Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant