Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up aiofiles warnings on 3.8 #754

Closed
simonw opened this issue May 4, 2020 · 2 comments
Closed

Clean up aiofiles warnings on 3.8 #754

simonw opened this issue May 4, 2020 · 2 comments
Labels
minor Minor bugs (not high priority)

Comments

@simonw
Copy link
Owner

simonw commented May 4, 2020

https://travis-ci.org/github/simonw/datasette/jobs/682624476

Lots of warnings like this:

/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33

/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33

  /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead

    def method(self, *args, **kwargs):

/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/__init__.py:27

  /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/__init__.py:27: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead

    def _open(file, mode='r', buffering=-1, encoding=None, errors=None, newline=None,
@simonw simonw added the minor Minor bugs (not high priority) label May 4, 2020
@simonw
Copy link
Owner Author

simonw commented May 4, 2020

I think those will be fixed by an upgrade to aiofiles 0.5.0:

Tinche/aiofiles@v0.4.0...v0.5.0

@simonw simonw mentioned this issue May 4, 2020
Merged
@simonw
Copy link
Owner Author

simonw commented May 4, 2020

Sure enough this run https://travis-ci.org/github/simonw/datasette/jobs/674415040 from that PR no longer shows the warnings.

simonw pushed a commit that referenced this issue May 4, 2020
@dependabot-preview
Update aiofiles requirement from ~=0.4.0 to >=0.4,<0.6 (#725)
985e594 
Refs #754

Updates the requirements on [aiofiles](https://github.com/Tinche/aiofiles) to permit the latest version.
- [Release notes](https://github.com/Tinche/aiofiles/releases)
- [Commits](Tinche/aiofiles@v0.4.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@simonw simonw closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor Minor bugs (not high priority)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw