Include LICENSE in sdist #1043
Merged
Include LICENSE in sdist #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1043 +/- ##
=======================================
Coverage 84.65% 84.65%
=======================================
Files 28 28
Lines 3924 3924
=======================================
Hits 3322 3322
Misses 602 602 Continue to review full report at Codecov.
|
|
Thanks. I'll push a source release of |
|
I misunderstood - |
simonw
pushed a commit
that referenced
this pull request
Oct 24, 2020
|
Sorry, I was out of the loop this weekend. The missing sdists were in some the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for
datasette!This PR adds the
LICENSEto source distributions, which seems the norm for Apache-2.0 stuff.I noticed the 0.50.2 sdist doesn't ship
LICENSE, but the 0.5.2whldoes, so I'm assuming the intent is to ship... and it's a one-liner!Motivation:
It might be a bit of a slog, but I'm looking to see about getting
datasette(and friends!) available on conda-forge. There are a few missing upstreams (asgi-csrf,python-basecov,mergedeep) and some of the plugins don't even appear to have tarballs (justwhl!), but the little stuff like licenses are nice to get out handled upstream vs separately grabbing them.