Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New explicit versioning mechanism #1060

Merged
merged 3 commits into from
Oct 29, 2020
Merged

New explicit versioning mechanism #1060

merged 3 commits into from
Oct 29, 2020

Conversation

simonw
Copy link
Owner

@simonw simonw commented Oct 28, 2020

  • Remove all references to versioneer
  • Re-implement versioning to use a static string baked into the repo
  • Ensure that string is output by datasette --version and /-/versions

Refs #1054

@simonw simonw added this to the 0.51 milestone Oct 28, 2020
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1060 into main will increase coverage by 6.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
+ Coverage   84.71%   91.13%   +6.42%     
==========================================
  Files          28       27       -1     
  Lines        3957     3677     -280     
==========================================
- Hits         3352     3351       -1     
+ Misses        605      326     -279     
Impacted Files Coverage Δ
datasette/cli.py 73.63% <100.00%> (+0.13%) ⬆️
datasette/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abcf022...4725d46. Read the comment docs.

@simonw simonw marked this pull request as ready for review October 29, 2020 03:37
@simonw simonw merged commit cefd058 into main Oct 29, 2020
@simonw simonw deleted the version branch October 29, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant