-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker Spatialite version to 5.0.1 + add support for Spatialite topology functions #1254
Conversation
…for Spatialite topology functions
Did you see my note on #1249 (comment) about a weird issue I was having with the |
Dockerfile
Outdated
@@ -13,13 +13,14 @@ RUN wget "https://www.sqlite.org/2020/sqlite-autoconf-3310100.tar.gz" && tar xzf | |||
RUN wget "http://www.gaia-gis.it/gaia-sins/freexl-sources/freexl-1.0.5.tar.gz" && tar zxf freexl-1.0.5.tar.gz \ | |||
&& cd freexl-1.0.5 && ./configure && make && make install | |||
|
|||
RUN wget "http://www.gaia-gis.it/gaia-sins/libspatialite-sources/libspatialite-4.4.0-RC0.tar.gz" && tar zxf libspatialite-4.4.0-RC0.tar.gz \ | |||
&& cd libspatialite-4.4.0-RC0 && ./configure && make && make install | |||
RUN git clone "https://git.osgeo.org/gitea/rttopo/librttopo.git" && cd librttopo && ./autogen.sh && ./configure && make && make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd feel more comfortable pinning this to a specific version rather than pulling the latest from the git repo.
Thanks for catching that documentation update! |
Codecov Report
@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
- Coverage 91.56% 91.51% -0.05%
==========================================
Files 34 34
Lines 4244 4244
==========================================
- Hits 3886 3884 -2
- Misses 358 360 +2
Continue to review full report at Codecov.
|
Oh wow I didn't even see that you had opened an issue about this so recently. I'll check on |
… version, as well as use the specific RT Topo 1.1.0 library
Dang, you're absolutely right. Spatialite 5.0 had been working fine for a plugin I was developing, but it apparently is broken in several other ways. |
What other breaks did you spot? |
This requires adding the RT Topology library (Spatialite changed to RT Topology from LWGEOM between 4.4 and 5.0), as well as upgrading the GEOS version (which is the reason for switching to
python:3.7.10-slim-buster
as the base image.)autoconf
andlibtool
are added to build RT Topology, and Spatialite is now built with--disable-minizip
(minizip wasn't an option in 4.4 and I didn't want to add another dependency) and--disable-dependency-tracking
which, according to Spatialite, "speeds up one-time builds"