Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword-only arguments for a bunch of internal methods #1823

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

simonw
Copy link
Owner

@simonw simonw commented Sep 27, 2022

Refs #1822


📚 Documentation preview 📚: https://datasette--1823.org.readthedocs.build/en/1823/

@simonw
Copy link
Owner Author

simonw commented Sep 27, 2022

I should update the documentation to reflect this change.

@simonw
Copy link
Owner Author

simonw commented Sep 27, 2022

Also need to do a bit more of an audit to see if there is anywhere else that this style should be applied.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 91.58% // Head: 92.50% // Increases project coverage by +0.91% 🎉

Coverage data is based on head (b545b6a) compared to base (5f9f567).
Patch coverage: 90.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1823      +/-   ##
==========================================
+ Coverage   91.58%   92.50%   +0.91%     
==========================================
  Files          36       35       -1     
  Lines        4444     4400      -44     
==========================================
  Hits         4070     4070              
+ Misses        374      330      -44     
Impacted Files Coverage Δ
datasette/utils/asgi.py 91.06% <88.23%> (ø)
datasette/app.py 94.11% <100.00%> (ø)
datasette/utils/shutil_backport.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant