Detect server start/stop more reliably. #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janl
force-pushed
the
test/more-reliable-wait
branch
3 times, most recently
from
0dc23e2
to
1fccdd1
Compare
This is useful, especially in testing, since your test hosts might not reliabliy start the server within two seconds, so we do a definite check before progressing. By the same token, after `kill $server_pid` wait for the pid to be gone from the process list. Since now the script can end prematurely, I also added a cleanup function to make sure the temporary certs are removed in any case. n.b. this could also be done with the use of `trap 'fn' ERR` but that felt like a bit too much magic for this short a script.
janl
force-pushed
the
test/more-reliable-wait
branch
from
1fccdd1
to
6a58fc7
Compare
|
This is great, thank you! |
|
Will link to this from my TIL shortly. |
aspiers
reviewed
Dec 20, 2022
| # | | don’t match on the previous grep | ||
| # | | | we don’t need the output | ||
| # | | | | | ||
| until ( ! ps ax | grep $server_pid | grep -v grep > /dev/null ); do |
There was a problem hiding this comment.
This can be simplified in a few different ways:
until ! ps -p $server_pid > /dev/null; do
until ! [ -e /proc/$server_pid ]; do
until ! kill -0 $server_pid 2>/dev/null; doThese have varying degrees of portability - don't have a Mac to hand, but I'm guessing they all work on all modern systems. They all assume that $server_pid cannot be the empty string, but I think that's safe in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful, especially in testing, since your test hosts might not reliabliy start the server within two seconds, so we do a definite check before progressing.
By the same token, after
kill $server_pidwait for the pid to be gone from the process list.Since now the script can end prematurely, I also added a cleanup function to make sure the temporary certs are removed in any case.
n.b. this could also be done with the use of
trap 'fn' ERRbut that felt like a bit too much magic for this short a script.📚 Documentation preview 📚: https://datasette--1965.org.readthedocs.build/en/1965/