Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid repeating primary key columns if included in _col args #2026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid repeating primary key columns if included in _col args #2026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion datasette/views/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,8 @@ async def table_post(self, request, db, database_name, table_name):
async def columns_to_select(self, table_columns, pks, request):
columns = list(table_columns)
if "_col" in request.args:
columns = list(pks)
_cols = request.args.getlist("_col")
columns = [pk for pk in pks if pk not in _cols]
bad_columns = [column for column in _cols if column not in table_columns]
if bad_columns:
raise DatasetteError(
Expand Down