Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actors_from_ids plugin hook and datasette.actors_from_ids() method #2181

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

simonw
Copy link
Owner

@simonw simonw commented Sep 8, 2023

Refs:

This plugin hook is feature complete - including documentation and tests.

I'm not going to land it in Datasette main until we've used it at least once though, which should happen promptly in development for Datasette Cloud.


📚 Documentation preview 📚: https://datasette--2181.org.readthedocs.build/en/2181/

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c263704) 92.68% compared to head (e1c5a9d) 92.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2181   +/-   ##
=======================================
  Coverage   92.68%   92.69%           
=======================================
  Files          40       40           
  Lines        6017     6025    +8     
=======================================
+ Hits         5577     5585    +8     
  Misses        440      440           
Files Changed Coverage Δ
datasette/app.py 94.43% <100.00%> (+0.03%) ⬆️
datasette/hookspecs.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@simonw simonw changed the title Prototype of actors_from_ids plugin hook actors_from_ids plugin hook and datasette.actors_from_ids() method Sep 8, 2023
@simonw
Copy link
Owner Author

simonw commented Sep 8, 2023

I've implemented this hook once now in:

And built and tested a debug tool for it in:

I'm now confident in the design of this plugin hook, I'm going to land it.

@simonw simonw marked this pull request as ready for review September 8, 2023 04:23
@simonw simonw merged commit b645174 into main Sep 8, 2023
19 checks passed
@simonw simonw deleted the actors-from-ids branch September 8, 2023 04:24
simonw added a commit that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant