Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design for table and database action menus #2282

Merged
merged 8 commits into from Feb 25, 2024
Merged

New design for table and database action menus #2282

merged 8 commits into from Feb 25, 2024

Conversation

simonw
Copy link
Owner

@simonw simonw commented Feb 23, 2024

Refs:

TODO:

  • Review if there is any leftover obsolete CSS, particularly inline or flex stuff relating to the .page-header
  • Maybe update style of other blue buttons slightly to match the new action buttons
  • Test on mobile / Safari / etc
  • Update pattern portfolio

@simonw simonw added the design label Feb 23, 2024
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (4341234) to head (02b5f55).

❗ Current head 02b5f55 differs from pull request most recent head ac9299a. Consider uploading reports for the commit ac9299a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
+ Coverage   92.41%   92.69%   +0.27%     
==========================================
  Files          42       41       -1     
  Lines        6382     6338      -44     
==========================================
- Hits         5898     5875      -23     
+ Misses        484      463      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonw
Copy link
Owner Author

simonw commented Feb 25, 2024

On iOS Safari:

C0934AEE-53D5-4E4E-AAEA-B6585DEFA844_1_201_a
2F64034D-83DC-4916-8F62-939EFDCC1C71_1_201_a
066B3F04-C6AA-4063-B6AB-6EEA834F3D2E_1_201_a
AD270AE7-9243-4111-BED6-CC15634063F6_1_201_a

@simonw simonw marked this pull request as ready for review February 25, 2024 20:51
@simonw simonw merged commit dfd4ad5 into main Feb 25, 2024
16 of 17 checks passed
@simonw simonw deleted the action-menus branch February 25, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant