Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency versions #389

Closed
wants to merge 3 commits into from
Closed

Bump dependency versions #389

wants to merge 3 commits into from

Conversation

simonw
Copy link
Owner

@simonw simonw commented Nov 20, 2018

No description provided.

@simonw
Copy link
Owner Author

simonw commented Nov 20, 2018

The problem is Sanic. Here's the error I'm getting:

(venv) datasette $ pytest -x 
============================================================= test session starts ==============================================================
platform darwin -- Python 3.7.1, pytest-4.0.0, py-1.7.0, pluggy-0.8.0
rootdir: /Users/simonw/Dropbox/Development/datasette, inifile:
collected 258 items                                                                                                                            

tests/test_api.py ...................F

=================================================================== FAILURES ===================================================================
_______________________________________________________ test_table_with_slashes_in_name ________________________________________________________

app_client = <tests.fixtures.TestClient object at 0x10ada7d68>

    def test_table_with_slashes_in_name(app_client):
        response = app_client.get('/fixtures/table%2Fwith%2Fslashes.csv?_shape=objects&_format=json')
>       assert response.status == 200
E       AssertionError: assert 404 == 200

That's because something about how Sanic handles escape characters in URLs changed between 0.7.0 and 0.8.3.

@simonw
Copy link
Owner Author

simonw commented Nov 13, 2019

This is very obsolete now.

@simonw simonw closed this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant