Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku --include-vcs-ignore #407

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Heroku --include-vcs-ignore #407

merged 2 commits into from
Feb 6, 2019

Conversation

simonw
Copy link
Owner

@simonw simonw commented Feb 6, 2019

Should mean datasette publish heroku can work under Travis, unlike this failure:

https://travis-ci.org/simonw/fivethirtyeight-datasette/builds/488047550

2.25s$ datasette publish heroku fivethirtyeight.db -m metadata.json -n fivethirtyeight-datasette
tar: unrecognized option '--exclude-vcs-ignores'
Try 'tar --help' or 'tar --usage' for more information.
 ▸    Command failed: tar cz -C /tmp/tmpuaxm7i8f --exclude-vcs-ignores --exclude
 ▸    .git --exclude .gitmodules . >
 ▸    /tmp/f49440e0-1bf3-4d3f-9eb0-fbc2967d1fd4.tar.gz
 ▸    tar: unrecognized option '--exclude-vcs-ignores'
 ▸    Try 'tar --help' or 'tar --usage' for more information.
 ▸    
The command "datasette publish heroku fivethirtyeight.db -m metadata.json -n fivethirtyeight-datasette" exited with 0.

The fix for that issue is to call the heroku command like this:

heroku builds:create -a app_name --include-vcs-ignore

Seeing if I can get this branch to be able to run
datasette heroku deploy on Travis CI running Ubuntu Trusty
@simonw simonw merged commit 195a5b3 into master Feb 6, 2019
@simonw
Copy link
Owner Author

simonw commented Feb 6, 2019

This helped my figure out what to do: heroku/heroku-builds#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant