Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply black to everything #449

Merged
merged 11 commits into from May 4, 2019

Conversation

Projects
None yet
1 participant
@simonw
Copy link
Owner

commented May 3, 2019

I've been hesitating on this for literally months, because I'm not at all excited about the giant diff that will result. But I've been using black on many of my other projects (most actively sqlite-utils) and the productivity boost is undeniable: I don't have to spend a single second thinking about code formatting any more!

So it's worth swallowing the one-off pain and moving on in a new, black-enabled world.

simonw added some commits May 3, 2019

Apply black to everything
I ran this:

    black datasette tests
Unit test enforcing black formatting
Only runs for Python 3.6 at the moment.

See python/black#425
Ensure test_black.py executes first under pytest
Otherwise it throws an exception because it gets disrupted by the
asyncio activity in the other tests.
Tweak version check
Because 3.5.1 > 3.5

@simonw simonw merged commit 35d6ee2 into master May 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.