Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface for creating and editing dashboards #44

Closed
5 tasks done
simonw opened this issue Mar 21, 2021 · 6 comments
Closed
5 tasks done

Interface for creating and editing dashboards #44

simonw opened this issue Mar 21, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Mar 21, 2021

This is currently only possible in the Django Admin. This will also implement edit permissions, taking over from #27.

Still todo:

  • Form to save a dashboard as a saved dashboard
  • If dashboard reloads with form errors, scroll down to the form
  • "Edit dashboard" link that links to the Django admin
  • Custom Django admin code to respect edit policies
  • Saved dashboard pages should show their visibility and edit policies
@simonw
Copy link
Owner Author

simonw commented Mar 21, 2021

I'm going to put this interface at at /dashboard/<slug>/edit/

Creating dashboards will start with a button on /dashboard/ - which will redirect the user to the new /dashboard/<slug>/edit/ page for further changes.

@simonw
Copy link
Owner Author

simonw commented May 8, 2021

For the first non-alpha release I'm going to link to the Django admin interface for edit.

@simonw
Copy link
Owner Author

simonw commented May 8, 2021

This means I need to write custom admin permission logic that takes the edit permissions and groups into account.

simonw added a commit that referenced this issue May 9, 2021
Plus permission logic controlling if they can edit, refs #44
@simonw
Copy link
Owner Author

simonw commented May 9, 2021

I'm going to allow super-users to reassign ownership of dashboards - but regular users will not be able to do that, even if they own the dashboard.

@simonw
Copy link
Owner Author

simonw commented May 9, 2021

Spotted an edge-case: if a user isn't staff they will not be able to access the edit interface, no matter what the edit policy is.

@simonw
Copy link
Owner Author

simonw commented May 9, 2021

That test failure turned out to be a Django version problem! Upgrading to the latest Django in my dev environment gave me the ability to replicate the bug.

simonw added a commit that referenced this issue May 9, 2021
@simonw simonw closed this as completed May 9, 2021
simonw added a commit that referenced this issue May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant