New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3-credentials put-objects
command
#68
Comments
If you pass a directory it will upload its contents to the root of the bucket: (Update no it won't see later comment).
You can use
Will create |
This should try to stay as consistent as possible with the new Lines 167 to 196 in 047020a
|
I wonder if this should support Would be useful. The I think |
What should
I can't think of many reasons people would want the first. I think I'm going to add the missing |
I'm not convinced that this is the right design decision. It makes sense for a single directory, but what if you do this?
Where It would be surprising if the contents of those folders were all flattened into the root of the bucket. |
If a user wants to upload the contents of a directory they can do so using
This would upload every file in that folder to the root of the bucket. |
Draft help:
|
Maybe the I'm going to try this without |
This command definitely needs a |
Yeah the
|
Did some manual testing:
|
While writing tests for this I leaned that the progress bar was output to stdout and not stderr. Fix for that is: with click.progressbar(length=size, label="Uploading", file=sys.stderr) as bar Applying |
It's frustrating when using
s3-credentials put-object
that you have to specify the key name each time, rather than deriving that from the filename:One way to fix this would be with a
s3-credentials put-objects
which works like this:It could accept multiple files (hence the plural name) and could also accept directories and recursively upload their contents.
The text was updated successfully, but these errors were encountered: