Allow column names to be reserved words

simonw · Jan 25, 2019 · 228d595 · 228d595
1 parent 6ad9037
commit 228d595
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/sqlite_utils/db.py b/sqlite_utils/db.py
@@ -318,7 +318,7 @@ def insert_all(
             """.format(
                 upsert="OR REPLACE" if upsert else "",
                 table=self.name,
-                columns=", ".join(all_columns),
+                columns=", ".join("[{}]".format(c) for c in all_columns),
                 rows=", ".join(
                     """
                     ({placeholders})

diff --git a/tests/test_create.py b/tests/test_create.py
@@ -36,6 +36,10 @@ def test_create_table(fresh_db):
             {"name": "Ravi", "age": 63},
             [{"name": "name", "type": "TEXT"}, {"name": "age", "type": "INTEGER"}],
         ),
+        (
+            {"create": "Reserved word", "table": "Another"},
+            [{"name": "create", "type": "TEXT"}, {"name": "table", "type": "TEXT"}],
+        ),
     ),
 )
 def test_create_table_from_example(fresh_db, example, expected_columns):