Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure with sqlite 3.34 in test_cli.py::test_optimize #209

Closed
meatcar opened this issue Dec 14, 2020 · 1 comment
Closed

Test failure with sqlite 3.34 in test_cli.py::test_optimize #209

meatcar opened this issue Dec 14, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@meatcar
Copy link
Contributor

meatcar commented Dec 14, 2020

pytest output:

...
============================== short test summary info ===============================
FAILED tests/test_cli.py::test_optimize[tables0] - assert 1662976 < 1662976
FAILED tests/test_cli.py::test_optimize[tables1] - assert 1667072 < 1662976
===================== 2 failed, 538 passed, 3 skipped in 34.32s ======================

Came across this while packaging sqlite-utils for NixOS, but it can be recreated it using the alpine:edge docker image as well as follows:

docker run --rm -it alpine:edge /bin/sh
# apk update && apk add git sqlite python3 gcc python3-dev musl-dev && python3 -m ensurepip
# git clone https://github.com/simonw/sqlite-utils.git
# cd sqlite-utils/
# pip3 install -e .[test]
# pytest

This definitely works on sqlite v3.33.

@simonw simonw added the bug Something isn't working label Jan 1, 2021
@simonw
Copy link
Owner

simonw commented Jan 1, 2021

I just hit this one too. Such a weird bug!

@simonw simonw closed this as completed in 33c759a Jan 1, 2021
simonw added a commit that referenced this issue Jan 1, 2021
Refs #209. Also updated copyright footer in documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants