Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.4 release is broken - includes a rogue line #226

Closed
simonw opened this issue Feb 6, 2021 · 0 comments
Closed

3.4 release is broken - includes a rogue line #226

simonw opened this issue Feb 6, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Feb 6, 2021

I started seeing weird errors, caused by this line:

sqlite-utils/sqlite_utils/cli.py

Lines 1 to 3 in f8010ca

import base64
from tests.test_cli import test_query_memory_does_not_create_file
import click

That was added by accident in 1b666f9

I'm surprised the tests didn't catch this!
@simonw simonw added the bug Something isn't working label Feb 6, 2021
simonw added a commit that referenced this issue Feb 6, 2021
@simonw
Remove rogue import, refs #226
7d04565
@simonw simonw closed this as completed in 726219c Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw