.transform(types=) turns rowid into a concrete column

[simonw]

Noticed this in the tests for sqlite-utils memory in #282 - is it possible to fix this?

ec5174e

[simonw]

How easy is it to detect a rowid table? Is it as simple as .pks returning None? If so the documentation should mention that.

[simonw]

If this can be fixed it will be in the transform_sql() method.

[simonw]

>>> db = sqlite_utils.Database(memory=True)
>>> db["rowid_table"].insert({"name": "Cleo"})
<Table rowid_table (name)>
>>> db["regular_table"].insert({"id": 1, "name": "Cleo"}, pk="id")
<Table regular_table (id, name)>
>>> db["rowid_table"].pks
['rowid']
>>> db["regular_table"].pks
['id']

I think I need an introspection property for working out if a table is a rowid table or not.

[simonw]

sqlite-utils/sqlite_utils/db.py

Lines 805 to 810 in dc94f4b

	@property
	def pks(self):
	names = [column.name for column in self.columns if column.is_pk]
	if not names:
	names = ["rowid"]
	return names

So I can indeed detect a rowid table by looking for no is_pk columns.

[simonw]

I think this code is at fault:

sqlite-utils/sqlite_utils/db.py

Lines 1017 to 1023 in 5b25794

	sqls = []
	if pk is DEFAULT:
	pks_renamed = tuple(rename.get(p) or p for p in self.pks)
	if len(pks_renamed) == 1:
	pk = pks_renamed[0]
	else:
	pk = pks_renamed

It's using .pks which adds rowid if it's missing.