Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I forgot to include the changelog in the 3.25.1 release #414

Closed
simonw opened this issue Mar 11, 2022 · 7 comments
Closed

I forgot to include the changelog in the 3.25.1 release #414

simonw opened this issue Mar 11, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Mar 11, 2022

I pushed a release for https://github.com/simonw/sqlite-utils/releases/tag/3.25.1 but forgot to include the release notes in docs/changelog.rst

This means https://sqlite-utils.datasette.io/en/stable/changelog.html isn't showing them.

@simonw simonw added the bug Something isn't working label Mar 11, 2022
@simonw
Copy link
Owner Author

simonw commented Mar 11, 2022

Two options:

  • Delete and recreate the release on GitHub, triggering it to be fixed on Read The Docs (as the stable version) - but cancel the push to PyPI, since that platform doesn't allow package versions to be over-written and in this case since the changelog file isn't included in the PyPI package there should be no change at all
  • Push a 3.25.2 release.

I'm going to try and do that first option.

simonw added a commit that referenced this issue Mar 11, 2022
@simonw
Copy link
Owner Author

simonw commented Mar 11, 2022

I deleted both the release and the tag from GitHub using the web interface.

@simonw
Copy link
Owner Author

simonw commented Mar 11, 2022

I created a new tag and release: https://github.com/simonw/sqlite-utils/releases/tag/3.25.1

And I cancelled the publish workflow: https://github.com/simonw/sqlite-utils/actions/runs/1970415399

@simonw
Copy link
Owner Author

simonw commented Mar 11, 2022

On ReadTheDocs that triggered a new stable build but it didn't seem to trigger a new build of 3.25.1: https://readthedocs.org/projects/sqlite-utils/builds/

image

@simonw
Copy link
Owner Author

simonw commented Mar 11, 2022

OK that fixed it here: https://sqlite-utils.datasette.io/en/stable/changelog.html

I'm going to trigger a rebuild of 3.25.1 too:

CleanShot 2022-03-11 at 10 37 33@2x

@simonw
Copy link
Owner Author

simonw commented Mar 11, 2022

@simonw
Copy link
Owner Author

simonw commented Mar 11, 2022

That fixed it:

image

@simonw simonw closed this as completed Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant