Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add social media cards #21

Closed
simonw opened this issue Sep 1, 2020 · 6 comments
Closed

Add social media cards #21

simonw opened this issue Sep 1, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Sep 1, 2020

So sharing on twitter is nicer.
@simonw simonw added the enhancement New feature or request label Sep 1, 2020
@simonw
Copy link
Owner Author

simonw commented Sep 1, 2020

I'd really love to have screenshots of the posts as the social media card images. I wonder what the best way to achieve that would be?

@simonw
Copy link
Owner Author

simonw commented Sep 1, 2020

Built https://github.com/simonw/puppeteer-screenshot for screenshots. It takes a secret key, so the URL is something like:

https://puppeteer-screenshot.simonw.vercel.app/til.simonwillison.net/til/til/pytest_subprocess-server.md?key=...

I'm going to store the images in the database and use https://github.com/simonw/datasette-media to serve them.

simonw added a commit that referenced this issue Sep 1, 2020
@simonw
Social media cards, refs #21
dde5de6
@simonw
Copy link
Owner Author

simonw commented Sep 1, 2020

Added two new secrets to this repo:

Secrets

@simonw
Copy link
Owner Author

simonw commented Sep 1, 2020

Shipped and tweeted: https://twitter.com/simonw/status/1300868423774212096

It would be better if the aspect ratio was 2x1 though.

_2__Simon_Willison_on_Twitter___Added_social_media_preview_cards_to_my_TILs__https___t_co_H4Hg39EG9g____Twitter

@simonw simonw mentioned this issue Sep 1, 2020
Closed
simonw added a commit that referenced this issue Sep 1, 2020
@simonw
Use 2x1 aspect ratio screenshots, refs #21
921026c 
Now also rebuilds DB from scratch if REBUILD in commit message.
@simonw
Copy link
Owner Author

simonw commented Sep 1, 2020

That GitHub Actions run (attempting to rebuild everything) took too long so I'm rebuilding and deploying once on my laptop.

@simonw
Copy link
Owner Author

simonw commented Sep 1, 2020

Shipped. Demo https://twitter.com/simonw/status/1300884226066190337

Simon_Willison_on_Twitter___Twitter_cards_look_better_at_2x1_aspect_ratio_so_I_added_viewportWidth__and_viewportHeight__arguments_to_my_screenshot_service_-_fresh_demo__https___t_co_S1O9f0yWZh____Twitter

@simonw simonw closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw