Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SIMP-2433) Manage centralized certs in pki::copy #31

Merged
merged 4 commits into from
Jan 6, 2017
Merged

(SIMP-2433) Manage centralized certs in pki::copy #31

merged 4 commits into from
Jan 6, 2017

Conversation

nick-markowski
Copy link
Member

  • We have made the decision to centralize application certificates
    when simp is managing pki (simp_options::pki => true or 'simp').
    This update re-tools pki::copy to better handle managing certs
    in /etc/pki/simp_apps.

SIMP-2433 #close
SIMP-2432 #comment updated pki::copy, begin refactor in module space

- We have made the decision to centralize application certificates
  when simp is managing pki (simp_options::pki => true or 'simp').
  This update re-tools pki::copy to better handle managing certs
  in /etc/pki/simp_apps.

SIMP-2433 #close
SIMP-2432 #comment updated pki::copy, begin refactor in module space
@review-ninja
Copy link

ReviewNinja

Copy link
Member

@trevor-vaughan trevor-vaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual code review 👍

Copy link
Member

@trevor-vaughan trevor-vaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nick-markowski I made a few updates. If you're OK with them, go ahead and merge (after cleaning up the commit message)

@nick-markowski nick-markowski merged commit c2d1065 into simp:master Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants