Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SIMP-7974) Add new GLCI pipeline features #67

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

op-ct
Copy link
Member

@op-ct op-ct commented Jul 22, 2020

The patch adds enhanced features to SIMP Puppet modules' standardized
GitLab CI pipeline:

  • spec and acceptance tests only run when relevant files have changed
  • The CI variable SIMP_FULL_MATRIX is replaced by SIMP_MATRIX_LEVEL
  • spec and acceptance tests run at or above their SIMP_MATRIX_LEVEL
  • Jobs and the pipeline default to SIMP_MATRIX_LEVEL 1
  • The pipeline's SIMP_MATRIX_LEVEL can be changed via CI variable
    (via triggers, group/project settings, etc)
  • In the pipeline-triggering commit message, adding a line that starts
    with CI: MATRIX LEVEL 0 or CI: SKIP MATRIX will suppress all steps
    with SIMP_MATRIX_LEVEL 1-3

There is an important caveat: because of the way GitLab CI pipelines
determine changes, a file that hasn't changed between --amend +
force-pushed updates will not trigger the matrix again. This affects
scheduled and triggered pipelines.

  • To solve this scenario, setting the CI variable SIMP_FORCE_MATRIX = yes in a scheduled pipeline or pipeline trigger will ensure that all
    jobs at the current SIMP_MATRIX_LEVEL are run, regardless of what
    has changed (or not).

CI: SKIP_MATRIX
SIMP-8032 #close
SIMP-7974 #comment Add file-match CI runs to pupmod-simp-pki
SIMP-7975 #comment Add SIMP_MATRIX_LEVEL checks to pupmod-simp-pki

The patch adds enhanced features to SIMP Puppet modules' standardized
GitLab CI pipeline:

* spec and acceptance tests _only_ run when relevant files have changed
* The CI variable `SIMP_FULL_MATRIX` is replaced by `SIMP_MATRIX_LEVEL`
* spec and acceptance tests run at or above their `SIMP_MATRIX_LEVEL`
* Jobs and the pipeline default to `SIMP_MATRIX_LEVEL` 1
* The pipeline's `SIMP_MATRIX_LEVEL` can be changed via CI variable
  (via triggers, group/project settings, etc)
* In the pipeline-triggering commit message, adding a line that starts
  with `CI: MATRIX LEVEL 0` or `CI: SKIP MATRIX` will suppress all steps
  with `SIMP_MATRIX_LEVEL` 1-3

There is an important caveat: because of the way GitLab CI pipelines
determine `changes`, a file that hasn't changed between `--amend` +
force-pushed updates _will not trigger the matrix again_.  This affects
scheduled and triggered pipelines.

* To solve this scenario, setting the CI variable `SIMP_FORCE_MATRIX =
  yes` in a scheduled pipeline or pipeline trigger will ensure that all
  jobs at the current `SIMP_MATRIX_LEVEL` are run, regardless of what
  has changed (or not).

CI: SKIP_MATRIX
SIMP-8032 #close
[SIMP-7974] #comment Add file-match CI runs to pupmod-simp-pki
[SIMP-7975] #comment Add `SIMP_MATRIX_LEVEL` checks to pupmod-simp-pki

[SIMP-7974]: https://simp-project.atlassian.net/browse/SIMP-7974
[SIMP-7975]: https://simp-project.atlassian.net/browse/SIMP-7975
Copy link
Member

@trevor-vaughan trevor-vaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👻

@trevor-vaughan trevor-vaughan merged commit d41fce7 into simp:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants